[GitHub] cloudstack pull request: findbugs: write to static from instance

2015-07-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/539 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: findbugs: write to static from instance

2015-07-07 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/539#discussion_r34026647 --- Diff: server/src/com/cloud/api/auth/APIAuthenticationManagerImpl.java --- @@ -52,17 +55,25 @@ public void setApiAuthenticators(List authenticators)

[GitHub] cloudstack pull request: findbugs: write to static from instance

2015-07-06 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/539#issuecomment-119087564 @bhaisaab @karuturi @jburwell @everyone: can I get a second LGTM? --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cloudstack pull request: findbugs: write to static from instance

2015-07-06 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/539#issuecomment-118848535 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] cloudstack pull request: findbugs: write to static from instance

2015-06-29 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/539 findbugs: write to static from instance these are the trivial cases of ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD as reported by findbugs You can merge this pull request into a Git repo