[GitHub] cloudstack pull request: dynamic-roles: remove unnecessary order b...

2016-05-18 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220236481 @swill I've tested dynamic-roles features both with maven and rpms. I've tested the rpm/deb packages, including upgrade cases using this repository: (latest master an

[GitHub] cloudstack pull request: dynamic-roles: remove unnecessary order b...

2016-05-18 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220098373 OK, I will run this through my CI right now and if it comes back clean I will get it into this freeze. --- If your project is set up for it, you can reply to this em

[GitHub] cloudstack pull request: dynamic-roles: remove unnecessary order b...

2016-05-18 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220091668 @swill I got a report that the GenericDaoBase generate query with multiple filters (order by clauses) may fail for MySQL: SELECT role_permissions.id, role_per

[GitHub] cloudstack pull request: dynamic-roles: remove unnecessary order b...

2016-05-18 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220030012 Do you have reports already of this causing problems? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: dynamic-roles: remove unnecessary order b...

2016-05-18 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1551 dynamic-roles: remove unnecessary order by ID On some MySQL server envs, this may cause a SQL statement error, though I was unable to reproduce it. Since it's not needed, an order by 'sort_or