my bad, I would like to see "$LGTM" (as in on the start of a line),
though. This looks like a comment at first.
On Fri, Jul 10, 2015 at 3:42 PM, sateesh-chodapuneedi
wrote:
> Github user sateesh-chodapuneedi commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/568#issu
Github user sateesh-chodapuneedi commented on the pull request:
https://github.com/apache/cloudstack/pull/568#issuecomment-120414615
@DaanHoogland
I think there are 2 LGTM on this one - from @sanju1010 & @kishankavala
> sanju1010 added a note a day ago
> Need to
I don't see two LGTM on this one. What happened?
On Fri, Jul 10, 2015 at 6:20 AM, asfgit wrote:
> Github user asfgit closed the pull request at:
>
> https://github.com/apache/cloudstack/pull/568
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply ap
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/568
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/568#issuecomment-119917422
Looks good to me.
Commented on older PR earlier.
PR https://github.com/apache/cloudstack/pull/552 can be removed
---
If your project is set up for it, y
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/568#discussion_r34226433
--- Diff: test/integration/component/test_dhcp_dns_offload.py ---
@@ -0,0 +1,2126 @@
+# Licensed to the Apache Software Foundation (ASF) under one
GitHub user jayapalu opened a pull request:
https://github.com/apache/cloudstack/pull/568
dhcp/dns offload feature config dirve changes for vm migration
Added vm migration changes for config drive.
Added integration test for this.
You can merge this pull request into a Git repos