[GitHub] cloudstack pull request: config: doc: add default value 10 in desc...

2015-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/777 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: config: doc: add default value 10 in desc...

2015-09-07 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/777#issuecomment-138310467 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

Re: [GitHub] cloudstack pull request: config: doc: add default value 10 in desc...

2015-09-06 Thread Daan Hoogland
Rafael, and other non committing contributors, committers are responsible for getting code merged and reverted if it breaks things in hindsight but not the only and sometimes not even the best people to judge code on its merits. Your opinion is very welcome to us all. thanks for the valuable cont

[GitHub] cloudstack pull request: config: doc: add default value 10 in desc...

2015-09-04 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/777#issuecomment-137879562 I do not know if I can give LGTM (I am not a committer), but if I can +1 LGTM. Errors in Jenkins are not related to this commit. --- If your project

[GitHub] cloudstack pull request: config: doc: add default value 10 in desc...

2015-09-04 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/777#issuecomment-137753131 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: config: doc: add default value 10 in desc...

2015-09-04 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/777 config: doc: add default value 10 in description for vm.network.nic.m… …ax.secondary.ipaddresses value hardcoded by commit 4925b9f6a126454215531998c461bf376ac6ab67 You can merge this