[GitHub] cloudstack pull request: build_asf.sh: fix debian changelog alteri...

2015-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1239 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: build_asf.sh: fix debian changelog alteri...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1239#issuecomment-164291346 @borisroman we should separate it from the CloudStack repo ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: build_asf.sh: fix debian changelog alteri...

2015-12-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1239#issuecomment-164291121 The changelog file will need to be handled more carefully. LGTM :+1: --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: build_asf.sh: fix debian changelog alteri...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1239#issuecomment-164290759 LGTM, let's merge on my review only as we don't have a second RM to review --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: build_asf.sh: fix debian changelog alteri...

2015-12-13 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1239 build_asf.sh: fix debian changelog altering The script already adds a new entry so we shouldn't replace the previous one. That is done only in the next version script. As discus