[GitHub] cloudstack pull request: bugfix ui/scripts/accounts.js L1339

2016-05-12 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1104#issuecomment-218959629 This needs to be rebased @wolf29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: bugfix ui/scripts/accounts.js L1339

2016-05-10 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1104#issuecomment-218375367 @wolf29 can you rebase --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cloudstack pull request: bugfix ui/scripts/accounts.js L1339

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1104#issuecomment-216204778 @wolf29 can you rebase against latest master and share state of your PR, thanks LGTM tag:easypr --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: bugfix ui/scripts/accounts.js L1339

2016-01-27 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1104#issuecomment-175681911 @wolf29 please rebase against latest and meld commits into a single commit --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cloudstack pull request: bugfix ui/scripts/accounts.js L1339

2015-11-23 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1104#issuecomment-158895941 @bhaisaab I think @wolf29 is trying to triage the sonarqube issues. @wolf29 We would like a ref to an issue with a patch, jira, coverity, findbugs is all fine.

[GitHub] cloudstack pull request: bugfix ui/scripts/accounts.js L1339

2015-11-23 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1104#issuecomment-158874087 LGTM, though are the additional commas causing any issue for you? --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: bugfix ui/scripts/accounts.js L1339

2015-11-22 Thread wolf29
Github user wolf29 commented on the pull request: https://github.com/apache/cloudstack/pull/1104#issuecomment-158857050 I have added in the second fix on that file, which should also fix the generated script file, I believe. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: bugfix ui/scripts/accounts.js L1339

2015-11-22 Thread wolf29
Github user wolf29 commented on the pull request: https://github.com/apache/cloudstack/pull/1104#issuecomment-158854379 @ustcweizhou - I can. I have never done one of these before, and wanted to make sure I understood the process before doing a whole lot of changes. --- If your pr

[GitHub] cloudstack pull request: bugfix ui/scripts/accounts.js L1339

2015-11-22 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1104#issuecomment-158817796 @wolf29 Can you create a PR with ALL related changes ? it is convenient for review and merge --- If your project is set up for it, you can reply to this em

[GitHub] cloudstack pull request: bugfix ui/scripts/accounts.js L1339

2015-11-22 Thread wolf29
GitHub user wolf29 opened a pull request: https://github.com/apache/cloudstack/pull/1104 bugfix ui/scripts/accounts.js L1339 This is a fix for one of the 2 problems in the first file in the stopper list for the https://analysis.apache.org/component_issues?id=org.apache.cloudstack%3