Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1552
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1552#issuecomment-221155776
Ok, so I have two LGTM both with validation that the code behaves as
expected. I think that is enough for this to get in. Thanks...
---
If your project is set up f
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1552#issuecomment-220974370
@swill I don't think so, CI doesn't test this feature. It is a script for
INSIDE Guest Instances.
---
If your project is set up for it, you can reply to this email an
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1552#issuecomment-220813347
Does this need CI?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1552#issuecomment-220349481
Can cofirm the dhcp folder on Ubuntu Trusty LTS (14.04) LGTM.
```
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Des
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1552#issuecomment-220261024
Good catch! I can confirm that under Ubuntu 16.04 (Xenial) that is where
the DHCP leases are stored.
root@example:~# lsb_release -a
No LSB modules are avai
GitHub user romain-dartigues opened a pull request:
https://github.com/apache/cloudstack/pull/1552
add DHCP lease folders for Ubuntu
Add "/var/lib/dhcp/*" to the search path for Ubuntu; tested under Ubuntu
Precise and Trusty, not yet with newer releases.
You can merge this pu
