[GitHub] cloudstack pull request: Using Profiler class, from the utils pack...

2015-06-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/525 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Using Profiler class, from the utils pack...

2015-06-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/524 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Using Profiler class, from the utils pack...

2015-06-24 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/525#issuecomment-115121390 this is not just more consistent but also more accurate timing as the time calculation is not done in a string concatenation. LGTM --- If your project

[GitHub] cloudstack pull request: Using Profiler class, from the utils pack...

2015-06-24 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/525 Using Profiler class, from the utils package, instead of System.currentTimeMillis() Class ClusterServiceServletImpl was using System.currentTimeMillis() in order to measure a method exe

[GitHub] cloudstack pull request: Using Profiler class, from the utils pack...

2015-06-24 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/524#issuecomment-115120064 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Using Profiler class, from the utils pack...

2015-06-24 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/524 Using Profiler class, from the utils package, instead of System.currentTimeMillis() Yesterday I found out that some methods' execution time are being measured based on System.currentTim