Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1012#issuecomment-153342236
This is already merged, I was running some tests. Documenting the results
here just in case we have to look back at it:
```
nosetests --with-marvin
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1012
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1012#issuecomment-152997882
for the record and again. LGTM I do not run a windows environment but since
Rafael has tested and we have some contributors needing this to proceed; let's
merg
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1012#issuecomment-152861243
I noticed you have already changed the code as a suggested.
I can give you now a LGTM.
---
If your project is set up for it, you can reply to this ema
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1012#issuecomment-152861124
The value is different for each user; the JVM will return the value from
%TEMP environment variable.
To give you an example, in my pc the returned valu
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1012#issuecomment-152721837
@rafaelweingartner Can you tell me what the output of java.io.tmpdir is on
Windows?
I'll look into your comment
---
If your project is set up for it, you can
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1012#issuecomment-152555222
Tested and that is not working on Windows.
I remember having fixed that into a PR that @DaanHoogland submitted
@wido, to fix the problem for windows
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1012#issuecomment-152541675
@DaanHoogland I think it was @SudharmaJain
As long as the build still works on Linux/Mac we didn't break anything. I'm
positive it's now also fixed on Windows.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1012#issuecomment-152536606
this lgtm but I am not running on any windows machines. @wido do you
remember who the people that were bothered were and can you ping thm to verify?
basical
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/1012
Use java.io.tmpdir instead of hardcoded /tmp
This was submitted earlier in PR #884 but that did not merge
properly.
This is a new PR with the same change.
You can merge this pull requ
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/884#issuecomment-152127321
@wido Would be nice if the commit hash changed, so Github doesn't recognise
it as already being merged.
---
If your project is set up for it, you can reply to t
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/884#issuecomment-152127233
@wido Please send a new PR with this commit, I tried merging it again but
that gives issues. We can proceed fast with this when you link the new one to
this PR.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/884#issuecomment-152114694
@remibergsma ping? ^^
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/884#issuecomment-148661785
@remibergsma This PR is marked as closed, but it was actually reverted.
Although it's not a bugfix, it is a fix for the Unit Tests on Windows. Do
we want to mer
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/884#issuecomment-143177747
@wido Great, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/884#issuecomment-143175301
@remibergsma Oops! I missed that e-mail while working on it this morning.
I'll stay off master :)
---
If your project is set up for it, you can reply to this email and
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/884#issuecomment-143175003
Hi @wido please don't merge stuff right now (see
http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201509.mbox/browser)
It also broke the build, but it
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/884
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/884#issuecomment-142945491
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/884#issuecomment-142936013
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/884#issuecomment-142934797
LGTM -> Unit test works as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/884
Use java.io.tmpdir instead of hardcoded /tmp
Small fix to have the tests also work on other platforms
You can merge this pull request into a Git repository by running:
$ git pull https://githu
22 matches
Mail list logo
