[GitHub] cloudstack pull request: Upgrades from 4.4: disable foreign key ch...

2015-04-14 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/164#issuecomment-92714730 @terbolous @DaanHoogland normally I would oppose the change in db files, but since this only fixes for foreign key constraints and fixes upgrade issue. I'm going ahe

[GitHub] cloudstack pull request: Upgrades from 4.4: disable foreign key ch...

2015-04-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/164 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Upgrades from 4.4: disable foreign key ch...

2015-04-14 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/164#issuecomment-92712153 @remibergsma sure, let me test and merge this on 4.4, 4.5 and master --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Upgrades from 4.4: disable foreign key ch...

2015-04-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/164#issuecomment-92511939 which they can't at the moment anyway, because of this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Upgrades from 4.4: disable foreign key ch...

2015-04-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/164#issuecomment-92511872 The consequence is that users from 4.4 must upgrade to 4.5.1 and can not upgrade to 4.5.0 --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Upgrades from 4.4: disable foreign key ch...

2015-04-13 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/164#issuecomment-92511037 4.5.0 is already released, although not announced, should we then change files in that version? What is the consequence of moving this to the 4.5.1 upgrade scripts?

[GitHub] cloudstack pull request: Upgrades from 4.4: disable foreign key ch...

2015-04-13 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/164 Upgrades from 4.4: disable foreign key checks when altering them Upgrades from 4.4 where not working properly due to errors like this: ERROR 1833 (HY000): Cannot change column 'id':