[GitHub] cloudstack pull request: Show actual diff in commits after merge w...

2015-12-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1227 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Show actual diff in commits after merge w...

2015-12-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1227#issuecomment-164147061 LGTM, this is why we want to be merging code instead of rebasing, no more commits on master! only merges! --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Show actual diff in commits after merge w...

2015-12-12 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1227#issuecomment-164146356 Nice! LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] cloudstack pull request: Show actual diff in commits after merge w...

2015-12-12 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1227#issuecomment-164139213 Cool! Also nice you put the screenshot to show it in action. LGTM Cheers, Wilder --- If your project is set up for it, you can reply t

[GitHub] cloudstack pull request: Show actual diff in commits after merge w...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1227#issuecomment-164138076 Example of merging PR 1221: https://cloud.githubusercontent.com/assets/1630096/11761460/05e97f22-a0c4-11e5-8c4a-da8cf67c973e.png";> --- If your projec

[GitHub] cloudstack pull request: Show actual diff in commits after merge w...

2015-12-12 Thread remibergsma
GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1227 Show actual diff in commits after merge with git-pr / git-fwd-merge This shows the diff in commits after using `git-pr` and `git-fwd-merge` tools, like this: ``` 44e8c92 Merge