Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1287
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-208431289
+1 based on code review and test results posted by @bvbharatk.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1287#discussion_r59233185
--- Diff: core/src/com/cloud/agent/api/SecurityGroupRulesCmd.java ---
@@ -200,52 +167,43 @@ public String getSecIpsString() {
return sb.t
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1287#discussion_r59231793
--- Diff: core/src/com/cloud/agent/api/SecurityGroupRulesCmd.java ---
@@ -200,52 +167,43 @@ public String getSecIpsString() {
return sb.t
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-202238647
### ACS CI BVT Run
**Sumarry:**
Build Number 138
Hypervisor xenserver
NetworkType Advanced
Passed=106
Failed=0
Skipped=4
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-172354935
What I did not understand is that when I read I think, represent what? Into
what? What format?
Reading the method call I know it is doing somethin
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-172353941
Thanks @rafaelweingartner. as for your last remark
```
Your code as always is great, I would just suggest some more improvement at
the new method you c
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-172347935
@DaanHoogland, that is great.
Those points I lifted up were merely suggestions on how to improve the code
a little bit more. Actually, in mos
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-172341007
@rafaelweingartner I gave you your way more then I intended to with respect
to comments. Please have a look if this satisfies your need/requirements.
---
If y
On Sat, Jan 16, 2016 at 12:57 PM, rafaelweingartner
wrote:
> Github user rafaelweingartner commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1287#issuecomment-172196150
>
> @DaanHoogland,
> I reviewed your code and I have a few suggestions/questions.
>
>
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-172245992
@DaanHoogland Can't test it as we don't use security groups.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-172234191
@rafaelweingartner @DaanHoogland,
Personally, I don't see a problem using final declarations for those
attributes. They all do seem to contain information t
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-172196150
@DaanHoogland,
I reviewed your code and I have a few suggestions/questions.
Are we really going to use final in all of our variables/attribute
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-172194485
Based on the code yes, @DaanHoogland . Couldn't run any tests on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-172191645
@wido is that a LGTM
@schubergphilis ?
@rafaelweingartner or any of the other brazilian colleagues?
@shapeblue ?
---
If your project is set up for
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-169134419
Based on the code I don't see anything dangerous though. It still compiles
I see ;)
---
If your project is set up for it, you can reply to this email and have your
re
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-168992910
@wido I have not changed logic so am trusting the unit tests and wrote an
extra. A run of integration tests might be required by some ;)
---
If your project i
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-168988361
Is there a way to test this quickly or do you have any results?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-167294361
force pushed squashed commits. not sure why SecurityGroupHttpClient got
replaced completely, probably line endings.
Last few runs nothing strange in the jen
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1287
SecurityGroupRulesCmd code cleanup
Wrote a test and cleaned some duplicate code with the objective to evaluate
the jenkins pull request process at builds.a.o
worthwhie to keep, IMHO.
20 matches
Mail list logo
