[GitHub] cloudstack pull request: Security group ingress/egress issues with...

2016-05-02 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/843#discussion_r61723868 --- Diff: scripts/vm/hypervisor/xenserver/vmops --- @@ -356,18 +356,25 @@ def allow_egress_traffic(session): return 'false' ret

[GitHub] cloudstack pull request: Security group ingress/egress issues with...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/843#issuecomment-216190725 @jayapalu please rebase against latest master and push -f, update on status of your PR --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack pull request: Security group ingress/egress issues with...

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/843#issuecomment-140729493 Also, what if the protocol version is greater than 6; what's the idea behind using protocol version to determine which data-structure type to use? --- If your proj

[GitHub] cloudstack pull request: Security group ingress/egress issues with...

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/843#issuecomment-140729245 @jayapalu isn't nethash type not supported on XenServer 6.2? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Security group ingress/egress issues with...

2015-09-16 Thread jayapalu
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/843#issuecomment-140724480 @bhaisaab can you please review this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: Security group ingress/egress issues with...

2015-09-16 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/843 Security group ingress/egress issues with xenserver 6.2 There is issue with the xenserver 6.2 ipset type nethash. Fixed it by adding nethash for ipset version 6 which is xenserver 6.5. For ipse