Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/856
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/856#issuecomment-142042882
Reopening PR that was closed by mistake
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user pedro-martins reopened a pull request:
https://github.com/apache/cloudstack/pull/856
Removed the empty class 'com.cloud.deploy.PlannerBase'
Removed the PlannerBase class because it is does not bring contribution to
ACS' code.
We changed com.cloud.deploy.FirstFit
Github user pedro-martins closed the pull request at:
https://github.com/apache/cloudstack/pull/856
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/856#issuecomment-141712362
@pedro-martins that is good that you removed and unused method in
com.cloud.deploy.DeploymentPlanner, however you forgot to remove all of the
implementatio
GitHub user pedro-martins opened a pull request:
https://github.com/apache/cloudstack/pull/856
Removed the empty class 'com.cloud.deploy.PlannerBase'
Removed the PlannerBase class because it is does not bring contribution to
ACS' code.
We changed com.cloud.deploy.FirstFitPl
