Github user GabrielBrascher closed the pull request at:
https://github.com/apache/cloudstack/pull/1484
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1484#issuecomment-208435439
@GabrielBrascher I think it is better to close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1484#issuecomment-208411575
Thanks for noting @pedro-martins.
As you stated this issue before, I will close mine PR.
Unless you think that another of proposed modifications are w
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1484#issuecomment-208088632
@rafaelweingartner
Done. the Jira is CLOUDSTACK-9343 if you can take a look.
Ty
---
If your project is set up for it, you can reply to this email and
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1484#issuecomment-208087293
@rafaelweingartner
I will open a Jira, the way that I found the problem was described in an
answer to Daan Hoogland in the same PR.
Ty
---
If your p
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1484#issuecomment-208086640
Where did you two analyzed that? How did you two find this problem?
How about opening a Jira ticket detailing the problem, so we can have a log
of it.
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1484#issuecomment-208086436
Hi @GabrielBrascher .
I think this params are removed in this PR
https://github.com/apache/cloudstack/pull/1447
=)
Ty.
---
If your project is set
GitHub user GabrielBrascher opened a pull request:
https://github.com/apache/cloudstack/pull/1484
Remove unused params from NetworkHelperImpl.start method
The contributions of this PR are:
- Removed unused params ("User" and "Account") from:
- method that does nothin
