[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2016-01-20 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1237#issuecomment-173185763 No reviews, so closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2016-01-20 Thread borisroman
Github user borisroman closed the pull request at: https://github.com/apache/cloudstack/pull/1237 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2015-12-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1237#issuecomment-164289083 @remibergsma @DaanHoogland Back to the point, who could we ping for a HyperV review? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2015-12-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1237#issuecomment-164288191 @borisroman @DaanHoogland Let's ask someone to test whether HyperV is still happy and then we'll know. --- If your project is set up for it, you can reply to t

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1237#issuecomment-164286918 @borisroman I can not decide based on these tests if the removal is ok, so to me they are useless --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2015-12-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1237#issuecomment-164285932 @DaanHoogland The integration tests show nothing broke on the KVM part, the code of course does need to be reviewed. But that doesn't mean the tests are useless.

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2015-12-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1237#issuecomment-164285459 @borisroman you know by now I agree on those principles but your integration test results are quite useless as we are talking about hyperv code. Let's do a sho

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2015-12-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1237#issuecomment-164285184 Integration tests ran fine! **Environment** - 2 KVM host on CentOS 7.1 - 1 Management Server on CentOS 7.1 - Agent + Common RPMs built from

[GitHub] cloudstack pull request: Remove unused folder(s)/file(s); HypervDu...

2015-12-13 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/1237 Remove unused folder(s)/file(s); HypervDummyResourceBase.java Dead code, never called and consist only of auto-generated methods. As a developer I want - a clean project to work