[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2016-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1223 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2016-01-17 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-172320075 For the record, LGTM from me. I'll merge the other PR (against 4.7) and close this one. --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2016-01-13 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-171289431 @syed Thanks for the fix, let's get it it. I'd like to merge it to 4.7 branch. Can you please close this PR, make a new one against 4.7 and then refer the new o

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2016-01-13 Thread lttmtins
Github user lttmtins commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-171262924 However just removing the ulimit as per suggestion also works for me. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2016-01-13 Thread lttmtins
Github user lttmtins commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-171251743 Actually the createtmplt.sh script starts with the hardcoded ulimit -f, but there is an '-S" flag within the script which would set the ulimit -f value to the Size

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2016-01-11 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-170667305 Hi Guys ( @bhaisaab, @DaanHoogland, @remibergsma ).Did you get a chance to look at this? I think we can remove this safely. --- If your project is set up for it, you

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2015-12-14 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-164469053 @DaanHoogland I agree, someone must have kept this limit way back and forgot about it. --- If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2015-12-12 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-164159535 40G sounds like an old fs limit. doesn't make sense nowadays. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2015-12-12 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-164140671 @remibergsma possible someone added this historically and nobody cared but now. I can check this later and get back to you. --- If your project is set up for it,

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2015-12-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-164132726 @syed Thanks! @bhaisaab @DaanHoogland Do you guys know why this was put in? It was in the original source import years ago. --- If your project is set

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2015-12-11 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-164039298 @remibergsma Done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2015-12-11 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-164015841 Hi @syed can you please squash the commits into one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2015-12-11 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1223 Remove template ulimit from createtmplt.sh and createvolume.sh Both createvolume.sh and createtmplt.sh have a 40GB hardcoded limit for the size of the template that gets created. I could not find