Github user PaulAngus closed the pull request at:
https://github.com/apache/cloudstack/pull/1087
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-216204381
@PaulAngus can you rebase against latest master and share state of your PR,
thanks
---
If your project is set up for it, you can reply to this email and have your
re
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-175680172
@PaulAngus please rebase against latest master and force push
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-161975241
@PaulAngus sounds like a reasonable solution to preserve custom logrotate
configurations on update. Can you push update the PR to remove commit ec698f5?
---
If y
Github user PaulAngus commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-161780789
So looking at the rpm spec options using +%config(noreplace) will cause a
new version of cloudstack-catalina (cloudstack-catalina.rpmnew) to be created
if cloudst
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-160431637
@PaulAngus please respond to the comment by @jburwell. After that we can
merge.
---
If your project is set up for it, you can reply to this email and have your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-160431621
LGTM, tested on CentOS7:
Logrotate is there:
```
[root@cs1 x86_64]# cat /etc/logrotate.d/cloudstack-catalina
/var/log/cloudstack/manage
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-158874419
LGTM, here's a rpm repo built out of this patch:
http://sb.bhaisaab.org/cloudstack/paul-rpmpr-1087/centos/paul-rpmpr-1087/
---
If your project is set up for it, y
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-157709261
@PaulAngus the change looks reasonable. Have you checked upgrading the RPM
to ensure that the any modified logrotate configuration files are left alone?
---
If y
Github user PaulAngus commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-157708006
Apologies.
https://issues.apache.org/jira/browse/CLOUDSTACK-9073 created
removal of /var/log/cloudstack-management
and addition of catalina log ro
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1087#issuecomment-157693735
@PaulAngus, every PR needs an issue on Apache Jira.
In addition, how did you test your changes? Some input will help us to test
it as well.
GitHub user PaulAngus opened a pull request:
https://github.com/apache/cloudstack/pull/1087
Remove extraenous log dir and add catalina.out log rotation.
remove unused /var/log/cloudstack-management directory
add cloudstack-catalina to logrotate.d directory so that
/var/log/cloud
12 matches
Mail list logo
