Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1453
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-218839589
LGTM @swill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-218791773
Can I get one more code review on this one??? Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-218053849
The one problem that is showing up in my CI does not appear to be related
to this PR, but this is the first time I have ever seen this error. If someone
else can con
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-218052889
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 1
Duration: 9h 04m 44s
```
**Summary of the p
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-207954572
I am having other problems (after the merge) in my test environment, not
related to the PR.
---
If your project is set up for it, you can reply to this email
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-207470758
@DaanHoogland I understand your points on requiring functional tests and
accept it.
Even after the rebase I did today, you had problems while testing
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-207466536
@rafaelweingartner the merge errors occured during testing as merging is
part of the integration tests. I agree with @swill about the test being needed
for thi
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-207423945
@swill , @DaanHoogland ,
Now everything is ok here.
@GabrielBrascher was a little busy, so I did the rebase for him.
---
If your project is set u
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-206983175
haha, trying to be. it is turning into a full time job...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-206982799
@swill thanks
I did not know that you were also watching this PR.
Man, you are literally everywhere; that is very good.
---
If your project is se
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-206982108
@rafaelweingartner yes, I will be running CI on this when the merge
conflicts have been resolved. nothing should be committed to master without CI
run against it IMO
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-206979289
@DaanHoogland, @GabrielBrascher,
The merge errors are occurring because the PR has merge conflicts.
A rebase should solve that.
@DaanHoogl
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-206965225
@GabrielBrascher I'm getting a merge error on this PR to master. can you
have a look and rebase if needed?
---
If your project is set up for it, you can reply
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-203484371
Thank you @pdube!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-203469470
I built, ran the unit tests and ran the server with the simulator. Thanks
for cleaning up! LGTM
[INFO]
--
GitHub user GabrielBrascher opened a pull request:
https://github.com/apache/cloudstack/pull/1453
Remove classes with no references
I used UCDetector (http://www.ucdetector.org/) as a plugin for Eclipse.
With this tool, I discovered a lot of code without any reference (variables,
17 matches
Mail list logo
