Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1494
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221666486
Thanks @swill and all involved !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221631597
This error is unrelated to this PR. This is ready to merge...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221631430
### CI RESULTS
```
Tests Run: 84
Skipped: 0
Failed: 0
Errors: 1
Duration: 5h 26m 59s
```
**Summary of the p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221409650
Oh, I think you were just resolving conflicts. I will run CI again just to
verify... Otherwise this is looking good. Thanks everyone...
---
If your project is set
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221409302
Was the only change since the last CI run the updating of the marvin test
(which I can't run anyway)?
---
If your project is set up for it, you can reply to this ema
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221394563
Thanks all folks, that gives the needed LGTM votes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221349421
Thanks @nlivens, great work cleaning.
The code LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221222391
@koushik-das, thanks for the review. Yes, all our model objects in the
Nuage VSP library are Serializable :)
---
If your project is set up for it, you can reply to
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221218765
LGTM. In some of the *Command.java and *Annswer.java classes, simple member
types has been replaced with types defined in the Nuage VSP library. As long as
all
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64358114
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
@@ -19,173 +19,43 @@
package
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221212242
@GabrielBrascher, @abhinandanprateek, resolved / commented on your notes
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64350508
--- Diff: engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java ---
@@ -432,4 +432,12 @@ public void removeRouterFromGuestNetwork(final long
router
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221160321
The AddNuageVspDeviceCmd can be upgraded to follow new RBAC pattern for
access permissions, api and response naming. (Look at CreateRoleCmd.java).
After t
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64323811
--- Diff: engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java ---
@@ -432,4 +432,12 @@ public void removeRouterFromGuestNetwork(final lo
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221087524
@rhtyd, @koushik-das, @remibergsma, @abhinandanprateek, @rafaelweingartner
anyone wants to further review ? We would like votes :)
Thanks!
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221023752
Travis CI failure : Is it a known issue ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64229436
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/util/NuageVspEntityBuilder.java
---
@@ -0,0 +1,370 @@
+//
+// Licensed to the Apache
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64229325
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -270,15 +258,15 @@ public PingCommand getCurren
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64080090
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/util/NuageVspEntityBuilder.java
---
@@ -0,0 +1,370 @@
+//
+// Licensed to the
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64078451
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResource.java
---
@@ -270,15 +258,15 @@ public PingCommand g
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220667799
Thanks @swill. Folks, pls review :)
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220622074
Can I get some code review on this one. It is looking to be in pretty good
shape otherwise. Thanks...
---
If your project is set up for it, you can reply to this e
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220596270
I am getting similar errors in other PRs, so I don't think they are related
to this PR.
---
If your project is set up for it, you can reply to this email and have yo
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220595991
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 2
Errors: 0
Duration: 4h 12m 50s
```
**Summary of the p
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220577391
@KrisSterckx yes you can; For instance ping @swill, @rhtyd, @koushik-das,
@remibergsma, @abhinandanprateek, @rafaelweingartner @GabrielBrascher any
reviews?
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220576106
Yes, correct, and thanks @DaanHoogland.
Could you initiate for more reviews; or anything i can do?
Thx
---
If your project is set up for it, y
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220458013
thanks @KrisSterckx, and to make it even more very clear: basically you
will only need to install acs and nuage and configure them correctly. neat. you
guys ar
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220394412
Hi @DaanHoogland
The architecture is
`cloudstack ---cmp--> nuage-vsp-acs-client ---cfg-->
Nuage VSP platform`
with
-
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220375273
So @KrisSterckx what are the copile, install, configuration and runtime
dependencies that users of your plugin will encounter? What do they need to buy
(except
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220326489
@DaanHoogland to your question :
We are embarking full CloudStack build automation as that gives us
cloudstack-nuagevsp-plugin <> nuagevsp-client-jar v
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220295965
this failed due to a jenkins config error. can you reopen it @nlivens ?
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220031468
great Nick, can you explain your choosen path for prosterity?
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-220019415
@remibergsma, @DaanHoogland, @swill, I've added an update to this PR.
We're stepping away from the no-redist model :)
---
If your project is set up for it, you
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-219087700
The CI does not cover the actual code, but instead makes sure nothing else
is broken by these changes. The test results provided by @nlivens show the
tests for the a
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-219086756
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 9h 17m 55s
```
**Associ
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-216582523
Can you force push again to see if we can get Jenkins green. The errors in
Jenkins are not ones I am used to seeing, but Travis is green, so I suspect
that a force p
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-216476619
Fixed issues with the added multi-zone support to "nuageTestCase.py" and
"test_nuage_vpc_network_multizone" testcase in "test_nuage_vpc_network.py":
Test ba
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-215553058
@nlivens please rebase as we have merge conflicts with master now.
Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-209912550
@remibergsma, I've added description :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-209893539
@nlivens Please add a description because this confuses me ;-) You guys go
the non-oss way? :-(
---
If your project is set up for it, you can reply to this em
41 matches
Mail list logo
