Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1486
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-219561259
Based on code review and the documentation cited by @remibergsma, the code
LGTM.
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-219541268
This one is ready to merge. I would love another code review on this one
as it is green and the CI is clean...
---
If your project is set up for it, you can reply t
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-219160164
Ok, we need one more review on this.
tag:needsreview tag:needreview
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-219157668
LGTM, tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-219082129
This one is looking pretty good. Can we get some code review on it so we
can move it forward. Thanks...
---
If your project is set up for it, you can reply to this
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-219031280
Resolved conflict
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-218811415
@remibergsma sorry to do this to you again. can you force push again. I
have pushed fixes to jenkins and travis this morning so hopefully we can get
this all green.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-218783498
Force pushed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-217605326
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 8h 49m 25s
```
**Associ
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-216228086
@remibergsma can do a push -f again, Travis failed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-216030568
Also force pushed this one again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-215988010
@swill force pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-208909441
I am not sure what is going on with Jenkins and Travis now days, but they
are being very flaky. Maybe the added load of people being more active is
messing with them
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-208793335
@swill force pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1486
Reimplement router.redundant.vrrp.interval setting
Global setting `router.redundant.vrrp.interval` is not used any more and it
is now set to a hardcoded 1.
This results in a failo
16 matches
Mail list logo
