Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-132121809
ok. will check PR #707. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-132115146
Hi @karuturi
The pull analysis failure is unrelated. --> Checkstyle errors in code I
didn't touch
The errors in the master build are being cause
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-132076968
looks there are compilation errors in nuage plugin.
jenkins builds failed
http://jenkins.buildacloud.org/job/build-master-noredist/4531/consoleText
http://j
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/705
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-131812682
Pending the checks LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-131810351
@borisroman first do internal restructure without changing the class
interface and next change the accessors. never mind however don't do double
work after I ma
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-131808466
@DaanHoogland I did the following;
- Refactored NicProfile.java (in 1 go)
- Changed names in every file llinked to NicProfile to make sure no
regressi
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-131806145
:+1: this is one of the cases I would have liked to see more commits. lgtm
in spite
---
If your project is set up for it, you can reply to this email and have
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/705
Refactored NicProfile.java for readability.
Only changed names and reorganized them! No functional implementation
change.
See issue CLOUDSTACK-8736 for ongoing effort to clean up net
