[GitHub] cloudstack pull request: Refactored Nic.java for readability.

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/707 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Refactored Nic.java for readability.

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/707#issuecomment-132444220 build is successful now. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Refactored Nic.java for readability.

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/707#issuecomment-132187698 @karuturi I see, fixed them in a new commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: Refactored Nic.java for readability.

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/707#issuecomment-132175228 I seeing below errors after applying this patch. Please do a noredist build as mentioned at https://cwiki.apache.org/confluence/display/CLOUDSTACK/How+to+build+Clou

[GitHub] cloudstack pull request: Refactored Nic.java for readability.

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/707#issuecomment-132154456 LGTM to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cloudstack pull request: Refactored Nic.java for readability.

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/707#issuecomment-131871473 @DaanHoogland You are right. I squashed to commits together so there will not be a non-working commit left. --- If your project is set up for it, you can reply t

[GitHub] cloudstack pull request: Refactored Nic.java for readability.

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/707#issuecomment-131864788 80bcfb1 and af199e7 are not atomic then? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: Refactored Nic.java for readability.

GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/707 Refactored Nic.java for readability. Only changed names and reorganized them! No functional implementation change. See issue CLOUDSTACK-8736 for ongoing effort to clean up network co