[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-149828561 @michaelandersen could you add the issue (CLOUDSTACK-8697) to the title of the pr and/or commit? loaded the file in python without errors, trusting the test

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-149807076 Ping @remibergsma @DaanHoogland @borisroman Anyone else with some time to test this PR and give a 2nd LGTM? The feature was fixed with PR #9

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-149515675 Although @michaelandersen did not change any router code, I ran some more tests just to testify the rebase. It all looks good! LGTM :+1: Te

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-149475560 First round of tests: ``` Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_haproxy_stats_on_all

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-149457679 Thanks for the rebase, @michaelandersen I will test this one as well! --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-149443163 @michaelandersen Travis failed due to a timeout. Could you please force push the commits again so it will re-run? Also, you may rebase with current master to inc

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-149249897 Hi @michaelandersen I will merge PR #940 and this one and test them together. This PR depends on the fix we added to CsLoadBalancer.py. Wil

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-149192133 @remibergsma @wilderrodrigues can you guys have a look when the build tests are finished? --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-149190264 fixed the first test === Marvin Init Logging Successful=== Successfully created account: test-TestInternalLb-SG7Y3N, id: d64ee2ea-2

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-148343622 @michaelandersen Thanks, I will have a look and run the test myself. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-148341058 squashed! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-148340689 nosetests --with-marvin --log-folder-path=/tmp/marvin/ --marvin-config=/data/shared/marvin/mct-zone1-kvm1.cfg -a tags=advanced test/integration/smoke/test_i

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-148340307 @michaelandersen Can you please squash the commits into a single one? Please also post the `nosiest` command so I can run the same test. Thanks! --- If

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-148337473 there should be a rule: ACCEPT tcp -- anywhere anywhere state NEW tcp dpt:8081 --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/933#issuecomment-148337333 the admin stats test fails because of a iptables misconfiguration on the ILBVM: === Marvin Init Logging Successful=== Successfully created account: te

[GitHub] cloudstack pull request: Refactored & Added Internal LB smoke test

GitHub user michaelandersen opened a pull request: https://github.com/apache/cloudstack/pull/933 Refactored & Added Internal LB smoke test Added 1VPC 2TIER internal lb roundrobin test Added 1VPC 1TIER internal lb admin stats test Refactored existing test Thanks @wilderrod