[GitHub] cloudstack pull request: Quota master WIP (just to follow changes)

2015-09-01 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/768#issuecomment-136950359 Previously, I expressed concerns that the pattern of opening and immediately closing transactions on ``TransactionLegacy`` was placing undue pressure on the underly

[GitHub] cloudstack pull request: Quota master

2015-09-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-136660371 New PR here: https://github.com/apache/cloudstack/pull/768 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Quota master WIP (just to follow changes)

2015-08-31 Thread bhaisaab
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/768 Quota master WIP (just to follow changes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack quota-master Alternatively

[GitHub] cloudstack pull request: Quota master

2015-08-31 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/689 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Quota master

2015-08-31 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r38385699 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days) {

[GitHub] cloudstack pull request: Quota master

2015-08-31 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-136335429 7.5kloc would justify 15klotc (kilo-lines of test code) I am not very worried about the quality of this code or the zeal of some bluely shaped programmers to ma

[GitHub] cloudstack pull request: Quota master

2015-08-31 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-136326696 @bhaisaab lot of code :) .. I will review tomorrow. Can you review 755 if possible? ;) --- If your project is set up for it, you can reply to this email and ha

[GitHub] cloudstack pull request: Quota master

2015-08-31 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-136326260 I will re-review later today (31 August 2015). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] cloudstack pull request: Quota master

2015-08-31 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-136322597 Changes included from the PR, branch rebased from latest master. Please help review - @karuturi @jburwell @DaanHoogland @remibergsma @kishankavala and other

[GitHub] cloudstack pull request: Quota master

2015-08-26 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r38060134 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: Quota master

2015-08-26 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r38059425 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/ServiceOfferingDaoImpl.java --- @@ -0,0 +1,85 @@ +// Licensed to the Apache S

[GitHub] cloudstack pull request: Quota master

2015-08-26 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-134875791 The Transaction open and close causing churn in database connection is based on the notion that these methods somehow open and close db connections. As

[GitHub] cloudstack pull request: Quota master

2015-08-26 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37952302 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: Quota master

2015-08-26 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37952287 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: Quota master

2015-08-26 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37952257 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (AS

[GitHub] cloudstack pull request: Quota master

2015-08-26 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37952296 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: Quota master

2015-08-26 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37952280 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundati

[GitHub] cloudstack pull request: Quota master

2015-08-26 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37952261 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (AS

[GitHub] cloudstack pull request: Quota master

2015-08-26 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37952242 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (AS

[GitHub] cloudstack pull request: Quota master

2015-08-26 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37952248 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (AS

[GitHub] cloudstack pull request: Quota master

2015-08-26 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37951326 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37951314 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37951243 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37951210 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37951236 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37951192 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37951181 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37951176 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37951139 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37951126 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37951112 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37951078 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37951007 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37951028 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950999 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950957 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950915 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950862 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950867 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950745 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950718 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950677 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950673 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950620 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950553 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,465 @@ +//Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950573 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950577 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950548 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950535 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950512 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950538 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950517 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950509 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950446 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950425 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950415 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950417 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950380 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950329 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950304 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950233 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950222 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950196 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Softw

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950152 --- Diff: server/src/com/cloud/api/dispatch/ParamProcessWorker.java --- @@ -294,6 +294,14 @@ private void setFieldValue(final Field field, final

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37950136 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-134855999 @jburwell was looking at com.cloud.utils.db.Transaction class the db is hardcoded in there: execute() short databaseId = TransactionLegacy.

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949885 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949858 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949824 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949748 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949700 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949667 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949627 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949568 --- Diff: server/src/com/cloud/api/dispatch/ParamProcessWorker.java --- @@ -294,6 +294,14 @@ private void setFieldValue(final Field field, final BaseCmd

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949444 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949195 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949186 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949093 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949107 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949073 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949069 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949049 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949030 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949008 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948979 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948942 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948934 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948903 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software Found

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948835 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948797 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948706 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948373 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947918 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947791 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947741 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947704 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947679 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947561 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947294 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947297 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the Apach

  1   2   3   >