Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1289
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-175500735
merging LGTM from @DaanHoogland and @bhaisaab
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-175479331
LGTM @agneya2001 master seems to be unfrozen you'll need one more review to
merge it yourself
---
If your project is set up for it, you can reply to this email an
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-175472278
This patch cleans up any find bug issues in cloud-framework-quota and
cloud-plugin-database-quota, verifiy output below. I think we should not delay
this @remibe
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-172597438
here is my original request to look at them:
http://markmail.org/message/fqv252o3p7hmzwxz
---
If your project is set up for it, you can reply to this email
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-172594983
@remibergsma I would have to dive into my original investigation again. I
am not sure who or where the others where created anymore. lat me markmail that
for y
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-172563054
What needs to be done to fix them all?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-172558281
again code LGTM. Let's quickly run it 3 out of 5 findbugs issues will be
fixed in this.
---
If your project is set up for it, you can reply to this email and
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-172418090
@remibergsma @bhaisaab made review changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-172197923
Ping @agneya2001 let's get this resolved soon :-) All those build failure
mails hurt my eyes..
---
If your project is set up for it, you can reply to this emai
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1289#discussion_r49316008
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java ---
@@ -310,14 +269,12 @@ public String getDeploymentPlanne
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-170455889
@agneya2001 can you help fix the issues, before the freeze. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1289#discussion_r49295533
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java ---
@@ -310,14 +269,12 @@ public String getDeploymentPlanner() {
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-169753995
Would you mind changing the comments over attributes âdetailsâ and
âisDynamicâ to proper java doc style? Additionally, what about changing
them to
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1289#discussion_r49101315
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java ---
@@ -310,14 +269,12 @@ public String getDeploymentPlanne
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-16848
Ping @bhaisaab @agneya2001 the quota plugin unit tests are failing in `4.7`
and `master` branches:
```
[INFO]
-
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-167625390
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1289#discussion_r48476072
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java ---
@@ -310,14 +269,12 @@ public String getDeploymentPlanner() {
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1289#issuecomment-167554252
Based on the code LGTM, tests running
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1289#discussion_r48474787
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java ---
@@ -312,7 +271,7 @@ public String getDeploymentPlanner() {
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1289
Quota: findbug fixes
Findbug fixes for cloud-framework-quota and cloud-plugin-database-quota.
You can merge this pull request into a Git repository by running:
$ git pull https://github
21 matches
Mail list logo
