Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1205
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1205#issuecomment-164293808
did a code review and trustin @bhaisaab his testing skills: LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1205#discussion_r47335119
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -233,9 +233,9 @@ public int compare(QuotaB
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1205#issuecomment-163885070
Alright, re-review it. LGTM.
cc @remibergsma @DaanHoogland
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user agneya2001 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1205#discussion_r47334512
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -233,9 +233,9 @@ public int compare(Quot
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1205#discussion_r47333986
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -233,9 +233,9 @@ public int compare(QuotaB
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1205#discussion_r47333902
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java
---
@@ -83,7 +83,12 @@ public void setDomainId(Long domainI
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1205#issuecomment-163882122
LGTM (tested on Abhi's env)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1205
QUOTA: Ensuring that the dates displayed are as per user expectations
When querying db we use start of next day to query quota usage for
today, but while displaying it to user we
Github user agneya2001 commented on the pull request:
https://github.com/apache/cloudstack/pull/1193#issuecomment-163479275
Closing this to change the case of the title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user agneya2001 closed the pull request at:
https://github.com/apache/cloudstack/pull/1193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1193#issuecomment-163330589
@agneya2001 Can you please change the title/commit to not only use capitals?
---
If your project is set up for it, you can reply to this email and have your
rep
GitHub user agneya2001 opened a pull request:
https://github.com/apache/cloudstack/pull/1193
QUOTA: ENSURING THAT THE DATES DISPLAYED ARE AS PER USER EXPECTATIONS
When querying db we use start of next day to query quota usage for
today, but while displaying it to user we
13 matches
Mail list logo
