Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136702586
With your comments, I fixed my Eclipse configuration on my Windows
environment, now I am using UNIX lines for ACS on windows.
On Tue, Sep 1, 201
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136698602
cat -v filename will show you line endings.
I figured the timezone issue. didnt want to wait for another day with
broken build. hence pushed it.
The recent
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136686182
@Karuturi, Sorry for the windows line endings (did you see that on log
files? I was not able to see anything there). Sometimes I jump between OS and
forget
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/762
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136640347
since this fixes slow build, I am going to merge this PR and push another
commit for line endings fix.
---
If your project is set up for it, you can reply to this
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136599746
@rafaelweingartner I see windows line endings in the new test file. Can you
fix that please?
Other than that, LGTM. once thats fixed I will merge
---
If your p
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136363041
The tests that have failed do not seem to be related to the code that was
changed.
---
If your project is set up for it, you can reply to this email and h
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136132050
Does anyone else have some ideas on how to test that code?
I am not comfortable with the test I coded, the test feels shallow.
---
If your project is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/762#issuecomment-136106558
LGTM, reviewing this I finally understand why we have a custom renderer at
all. The travis failing checks are unrelated timeouts.
---
If your project is set up
GitHub user rafaelweingartner opened a pull request:
https://github.com/apache/cloudstack/pull/762
Proposal for an improved CglibThrowableRenderer
Following our discussions on mailing list, here is a PR with a proposal for
an improvement on âCglibThrowableRendererâ. We would sti
10 matches
Mail list logo
