[GitHub] cloudstack pull request: Pep8 and some unit tests

2015-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/265 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Pep8 and some unit tests

2015-05-20 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/265#issuecomment-103829579 @bhaisaab For some reason this PR got the same commit of the previous PR (#262). @isoutham told me to ignore the previous one. So I'm now t

[GitHub] cloudstack pull request: Pep8 and some unit tests

2015-05-20 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/265#discussion_r30681931 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -555,35 +558,47 @@ def forward_vr(self, rule): self.portsT

[GitHub] cloudstack pull request: Pep8 and some unit tests

2015-05-19 Thread isoutham
Github user isoutham commented on the pull request: https://github.com/apache/cloudstack/pull/265#issuecomment-103648791 It looks like I have somehow managed to put the second PR in the first (was a seperate branch) not quite sure what I did here. Ignore the first and treat

[GitHub] cloudstack pull request: Pep8 and some unit tests

2015-05-19 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/265#issuecomment-103640249 It seems this PR came with the same commit as the previous one, that's why Travis is now building the #262 again. Did you create a second PR with the

[GitHub] cloudstack pull request: Pep8 and some unit tests

2015-05-19 Thread isoutham
GitHub user isoutham opened a pull request: https://github.com/apache/cloudstack/pull/265 Pep8 and some unit tests Fixes up a bunch of pep8 failure (trying to get rid of some jenkins failures) Also the first steps to a unit testing framework for the python code in the systemvm