Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1326
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-212910562
Thanks, I will merge this today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-212776381
@swill This has 2 LGTMs and also CI results. The failures are unrelated as
this PR only adds new test cases and no product code changes. This can be
merged.
-
@cloudstack.apache.org
Subject: [GitHub] cloudstack pull request: New test to validate starting vm
after ni...
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-206391435
Based on the code LGTM.
However, I am not sure if
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-206462142
I think all of the tests that fail regularly have been removed from that
test suite now. I believe we need all those tests passing, so we should review
the failures.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-206391435
Based on the code LGTM.
However, I am not sure if should consider those failed tests
("integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRang"
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1326#discussion_r58685208
--- Diff: test/integration/component/test_add_remove_network.py ---
@@ -1021,6 +1021,103 @@ def test_29_remove_nic_CS22503(self):
self.
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1326#discussion_r57545397
--- Diff: test/integration/component/test_add_remove_network.py ---
@@ -1021,6 +1021,103 @@ def test_29_remove_nic_CS22503(self):
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-201368034
_Link to logs Folder (search by build_no):_
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
### ACS CI BVT Run
**Sumarry:**
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-170358521
LGTM based on the code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user sanju1010 opened a pull request:
https://github.com/apache/cloudstack/pull/1326
New test to validate starting vm after nic removal and attach
Please refer bug CLOUDSTACK-9219 for more details.
Test Results:
==
Test to verify vm start after NIC rem
11 matches
Mail list logo
