[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149260118 @wilderrodrigues thanks, done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/948 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149257541 Hi @miguelaferreira I built ACS, RPMs from source and deploy a DC and ran few tests - although it was not needed to cover the changes. Anyway, it LG

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149191773 running it in the bubble now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149189859 I think it's fixed. I've been able to reproduce the issue both locally and in our CI server. And after the last force push the issue is gone in both environm

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149187828 This PR broke the maven build because dependency type was missing. Since apidocs does not generate a jar file, the dependency type has to be set to something

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149185286 Despite the fact that both builds are green, this PR as it is now breaks the maven build! Dug this up from the travis log: ``` [ERROR] Failed

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149168945 +1 LGTM based on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149165230 Thanks for this @miguelaferreira I've been running into this lately it might explain some issues in the bubble. --- If your project is set up for it, you can r

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/948#issuecomment-149165088 Travis stumbled on the same problem that I'm trying to fix here: https://travis-ci.org/apache/cloudstack/jobs/86030810 --- If your project is set up for it,

[GitHub] cloudstack pull request: Marvin module depends on APIdoc module

GitHub user miguelaferreira opened a pull request: https://github.com/apache/cloudstack/pull/948 Marvin module depends on APIdoc module When building the developer tools, if the build is sequential then the marvin module always gets build after the apidoc module. However, it the bui