Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219702802
Everything is duplicated in these results because I ran it a second time to
see if any of the errors cleared up on a second run.
---
If your project is set up for it
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219702648
### CI RESULTS
```
Tests Run: 170
Skipped: 0
Failed: 9
Errors: 0
Duration: 8h 52m 46s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219462622
I will run CI against it again today to see if it was an issue with that
environment.
---
If your project is set up for it, you can reply to this email and have your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219432167
@swill I can only reproduce the loadbalance errors, not the others. When I
look at the errors I doubt they are related. They work fine for me. But anyway,
no mo
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-21941
As you can see, I am still having a hell of a time with CI on this one. :(
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219413266
### CI RESULTS
```
Tests Run: 57
Skipped: 0
Failed: 4
Errors: 14
Duration: 5h 15m 07s
```
**Summary of the
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219137807
LGTM based on the manual testing above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219137482
Kill the Master VR:
---
If your project
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219137126
Hot add static route:
--
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219077134
@kiwiflyer thanks, I will run CI against it as well. It is good to have CI
posted as well as manual verification. that gives us the most confidence that
everything
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219076184
We have the fixes pulled in for testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219074669
I will rerun CI on this now. Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219037267
Pushed the fix and the tests now pass:
```
[root@cs2 cloudstack]# cat /tmp//MarvinLogs/test_network_7VU0DJ/results.txt
Test for port forwarding
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219005330
@swill @kiwiflyer I run the integration tests over night and they look much
better now. I only see some test fail in `smoke/test_network.py` that seem to
have t
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-218648913
Thanks for the hard work @remibergsma. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-218595232
Worked with @swill and @kiwiflyer and found the issue: one bit was missing
in the backport from Cosmic. Will look into that tomorrow.
---
If your project is se
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-218578631
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 24
Errors: 10
Duration: 10h 46m 24s
```
**Summary of th
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-218446038
Remi,
I'm seeing some issues with this PR, related to the way the VR scripts
utilize the argv file name for other uses. We spent a fair bit of time trying
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-216226822
Good improvement, LGTM (just code review)
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1470#discussion_r59294770
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -300,6 +303,8 @@ public ExecutionResult cr
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1470#discussion_r59294795
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigItemFacade.java
---
@@ -104,13 +109,25 @@ public static AbstractConfigI
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1470#discussion_r59294765
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -292,6 +292,9 @@ public ExecutionResult ex
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1470#discussion_r59294640
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigItemFacade.java
---
@@ -104,13 +109,25 @@ public static AbstractConfigI
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1470#discussion_r59290164
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigItemFacade.java
---
@@ -104,13 +109,25 @@ public static AbstractConfigItem
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-207082450
@remibergsma this looks like a good improvement to processing on the VR.
Please look through my feedback on #1465 regarding string and logging
performance. They
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1470
Make the generated json files unique to prevent concurrency issues
The json files now have UUIDs to prevent them from getting overwritten
before they've been executed. Prevents config to be
28 matches
Mail list logo
