Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/988#issuecomment-151810393
I can create a ticket, yes.
I plan to push more work to this pull request today/tomorrow that moves the
VirtualMachineName service and probably the UUID
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/988#issuecomment-151807919
@ProjectMoon impressive work. Can you create a jira ticket and describe it
(including functional incentive) and prepend the PR with the ticket id?
---
If your
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/988#discussion_r43242947
--- Diff:
plugins/network-elements/internal-loadbalancer/test/resources/lb_mgr.xml ---
@@ -36,7 +36,7 @@
-
+
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/988#issuecomment-151806516
@ProjectMoon THe stuff built and is running tests. You should be able to
force push it and it should build. unsure what we are looking for but probably
a proble
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/988#issuecomment-151658762
not sure what this is @ProjectMoon . I am running a test against your PR
overnight and will get back with what I may find, if anything.
---
If your project is
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/988#issuecomment-151557578
Looks like build keeps crashing. Should I maybe wait until later to run it?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/988#issuecomment-151553160
I think I also plan on refactoring this pull request further to make the
VirtualMachineNameService extensible similar to how some CloudStack adapters
work, so th
GitHub user ProjectMoon opened a pull request:
https://github.com/apache/cloudstack/pull/988
Make VirtualMachineName into an injectable service class
This pull request refactors the VirtualMachineName class into an injectable
dependency. It is one of the few remaining classes that a
