Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/741
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-136280810
Merging as 2 LGTMs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135777004
@DaanHoogland I figured it was something nice, but really wasn't sure about
what you meant exactly. Thank you!
---
If your project is set up for it, you can
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135776711
@miguelaferreira you know what ip my email lives on but to explain it to
the world; your approval is very much appreciated and binding to me.
---
If your proje
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135769001
Finished the tests... LGTM :+1:
[root@cs2 cloudstack]# python -m marvin.deployDataCenter -i
setup/dev/advanced.cfg
Log Folder Path:
/
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135769042
@DaanHoogland I get the feeling that by this time tomorrow I might have a
clue about what you meant
---
If your project is set up for it, you can reply to t
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135768876
@miguelaferreira your opinion feels like shackles to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135740495
will test it now...
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135739986
@wilderrodrigues can you please test this PR, it LGTM but my approval is
not binding!
---
If your project is set up for it, you can reply to this email and
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135415998
Setup (running all unit tests)
```
git fetch upstream pull/741/head:pr/741
git checkout pr/741
mvn clean install -Pdeveloper,systemvm
mvn -
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135394943
Thanks. I'm testing again with a clean environment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135394707
@miguelaferreira Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135393345
@koushik-das Then, please merge my PR (here:
https://github.com/koushik-das/cloudstack/pull/1)
And then @wilderrodrigues and myself will test this P
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135391862
Ran the test, LGTM.
test_02_scale_vm_without_hypervisor_specifics
(integration.smoke.test_scale_vm.TestScaleVm) ... === TestName:
test_02_scale_vm_witho
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-135358954
@koushik-das my PR to your PR is ready for you to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134935544
Cool! I would that that once @miguelaferreira is done with the tests and
the PR of PR, we can give a 2nd LGTM and then merge it.
Thanks, Miguel!
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134933068
Thanks @miguelaferreira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134905914
Sure, I can help you.
I will write the test for this PR and then make another PR that you can
merge into this one. PR of PR :) I love the github workflow!
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134901921
@miguelaferreira Sure a test can be added. Would you mind creating one and
send out a PR? You can start with the smoke/test_scale_vm.py and tweak it to
run only
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134897494
I completely understand the reasoning behind the header text, I just don't
agree that ".. following fixes .." is a good header for a commit. But given the
cu
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134895552
@miguelaferreira For running tests using simulator follow this
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Validating+check-ins+for+your+local+changes,
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/741#discussion_r37956660
--- Diff:
plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java
---
@@ -449,12 +450,34 @@ public Answer CleanupNetwork
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/741#discussion_r37955517
--- Diff:
plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java
---
@@ -449,12 +450,34 @@ public Answer CleanupNetworkRule
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134875242
HI @koushik-das
I've reviewed the code in this PR and it looks pretty good. I really like
what might seem like small things (lower-case on method na
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/741#discussion_r37952326
--- Diff:
plugins/hypervisors/simulator/src/com/cloud/agent/manager/MockVmManagerImpl.java
---
@@ -449,12 +450,34 @@ public Answer CleanupNetwork
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/741#issuecomment-134556011
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/741
Made following fixes in simulator
- Support for ScaleVmCommand/NetworkRulesVmSecondaryIpCommand in resource
layer
- Added support for scaling up a running VM in simulator
- Fixed som
27 matches
Mail list logo
