Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1471
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-221900033
Thanks guys. This one is ready...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-221891214
@remibergsma, sounds fair. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-221888640
@nlivens We shouldn't wait more than 2s, because that means the interface
is not there and will not come yet. Currently it's horribly slow because every
command
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-221873120
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 8h 23m 38s
```
**Associ
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-221824946
LGTM ð(code review only)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-221791953
@remibergsma, I understand your concern regarding the wait_until method.
Perhaps we could use the wait_until with a 2s interval and a max wait of 4s?
That's 1 retry
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-221762946
Can I get some code review on this one? Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-220032965
@remibergsma that failure is not one I commonly see, but I definitely do
have periodic failures in my environment which complain about "not being able
to connect to t
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-219944851
@swill Thanks for running the tests again. The error is `Failed to delete
network` so that's cleanup related. The failed one, is that the one that
randomly? Can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-219921338
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 1
Duration: 3h 58m 14s
```
**Summary of the p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-219862730
I am going to run a test against master to make sure nothing is broken in
this env and test again.
---
If your project is set up for it, you can reply to this email
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-219862519
Maybe this is a bit too aggressive or my CI environments are just too
slow...
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-219862285
### CI RESULTS
```
Tests Run: 40
Skipped: 0
Failed: 6
Errors: 44
Duration: 0h 26m 50s
```
**Summary of the
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-219029943
@jburwell Had a look at the `wait_until` method and I don't think it will
work well here. The problem is that when the router restarts, it has the full
config i
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-218854911
@jburwell Thanks, I'll look into that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-217773715
@remibergsma can you review @jburwell's comment and follow up in this
thread? Thanks...
---
If your project is set up for it, you can reply to this email and have y
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-216763100
@jburwell, I think that would be a nice solution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-216646244
@remibergsma you want to consider cribbing
[``wait_until``](https://github.com/apache/cloudstack/blob/12d8e53dd54d83242b3dabf2151249ab7963d5a8/tools/marvin/marvin/l
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-216524904
@remibergsma, down from 15 to 2 seconds is pretty big in terms of computing
time. Is there an internal retry in CS might this script give a timeout? I
think this is
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-216227004
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-208581097
This seems like a reasonable change to me. I am guessing 2 seconds is long
enough, but I don't really understand what other variables could add contention
and could
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1467
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1471
Lower the time we wait for interfaces to appear
Waiting for interfaces is tricky. They might never appear.. for example
when we have entries in `/etc/cloudstack/ips.json` that haven't been
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1467
Lower the time we wait for interfaces to appear after restart
Waiting for interfaces is tricky. They might never appear.. for example
when we have entries in `/etc/cloudstack/ips.json` that
25 matches
Mail list logo
