Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/919#issuecomment-148940768
@sarathkouk Please give this PR a meaningful title. Like: CLOUDSTACK-89xx:
short description
---
If your project is set up for it, you can reply to this email
Github user sarathkouk commented on the pull request:
https://github.com/apache/cloudstack/pull/919#issuecomment-148628286
Test Results
test_01_ldap (integration.component.test_ldap_autoImport.TestLdap1) ... ===
TestName: test_01_ldap | Status : SUCCESS ===
ok
test_02_ldap
GitHub user sarathkouk reopened a pull request:
https://github.com/apache/cloudstack/pull/919
Local cloudstack
LDAP: Auto Import and Trust AD
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarathkouk/cloudstack local_cloudstack
Github user sarathkouk commented on the pull request:
https://github.com/apache/cloudstack/pull/919#issuecomment-147398517
Thanks for the reviews. I'll update the code with necessary changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sarathkouk closed the pull request at:
https://github.com/apache/cloudstack/pull/919
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/919#issuecomment-147171622
@sarathkouk Thanks for the PR! See my comments on the code. Small issues,
and please make it PEP8 compliant. Also, add a Jira issue and be more
descriptive in wh
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707304
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707299
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707306
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707297
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707292
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707291
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707287
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707277
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707274
--- Diff: test/integration/component/test_ldap.py ---
@@ -21,13 +21,18 @@
#!/usr/bin/env python
from marvin.cloudstackTestCase import c
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707273
--- Diff: test/integration/component/test_ldap.py ---
@@ -21,13 +21,18 @@
#!/usr/bin/env python
from marvin.cloudstackTestCase import c
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707263
--- Diff: test/integration/component/test_ldap.py ---
@@ -151,13 +156,18 @@ def test_02_validateldapsecuritypatch(self):
self.services
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707251
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -1617,19 +1617,28 @@
"password": "password",
},
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/919#discussion_r41707148
--- Diff: test/integration/component/test_ldap_autoImport.py ---
@@ -0,0 +1,663 @@
+
+from marvin.cloudstackTestCase import cloudstackTestCase
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/919#issuecomment-147078784
@sarathkouk is there an issue in jira for this? what does it test more
precisely? People are more leanient on test code PRs then core code but I would
like to s
GitHub user sarathkouk opened a pull request:
https://github.com/apache/cloudstack/pull/919
Local cloudstack
LDAP: Auto Import and Trust AD
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarathkouk/cloudstack local_cloudstack
A
21 matches
Mail list logo
