[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-20 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/249#issuecomment-103938699 Builds fine, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-20 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/249#issuecomment-103934999 @resmo looks good to me, Travis is green too. Will merge tonight or tomorrow after some build tests. Thanks. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-20 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/249#issuecomment-103890479 @bhaisaab a good IDE helps indeed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-19 Thread resmo
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-19 Thread resmo
GitHub user resmo reopened a pull request: https://github.com/apache/cloudstack/pull/249 ListFirewallEgressRulesCmd: extend from BaseListTaggedResourcesCmd an… …d cleanup Fixes API duplicate parameter in docs and makes it more clear. Fixes a bunch of typos. You can

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-19 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/249#issuecomment-103431009 @resmo looks like an interface/type issue, see the error here: https://builds.apache.org/job/cloudstack-pull-requests/160/console I can help fix it next week, but i

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-19 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/249#issuecomment-103429103 @bhaisaab It's been a while since I coded JAVA, have no clue, why it is failing. May I ask you for a hint? --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-15 Thread resmo
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-15 Thread resmo
GitHub user resmo reopened a pull request: https://github.com/apache/cloudstack/pull/249 ListFirewallEgressRulesCmd: extend from BaseListTaggedResourcesCmd an… …d cleanup Fixes API duplicate parameter in docs and makes it more clear. Fixes a bunch of typos. You can

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-13 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/249#issuecomment-101671523 @resmo can you check and fix the build issue? Travis is failing too while building. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: ListFirewallEgressRulesCmd: extend from B...

2015-05-13 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/249 ListFirewallEgressRulesCmd: extend from BaseListTaggedResourcesCmd an… …d cleanup Fixes API duplicate parameter in docs and makes it more clear. Fixes a bunch of typos. You can me