Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1521
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-219775425
At this moment I don't see the benefit of doing a restructure as it will
kill any current work for somebody working on something in KVM.
I personally thing we
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-219653710
I will rebase again, if we do want this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-219651833
I am not against it, but we have more KVM Pull Requests open like #1545
At what point do we ask other PRs to be rebased after this one merges in?
---
If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-219101062
We have merge conflicts on this one. As soon as the merge conflicts are
sorted out, I will run CI against it and hopefully we can get some code reviews
quickly so we
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-219049934
@rhtyd @jburwell @wido @swill Are we not doing this? I see no :-1: but also
no LGTM
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-215552234
@DaanHoogland please rebase as master has caused merge conflicts...
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-215446492
Enjoying the discussion I would like to -1 for the entire refactor all at
once. I changed this project because it was feasible and convenient. I can see
myself
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-215438021
I would love to dump Maven for Gradle. However, I agree with @wido -- we
currently have much higher priorities to address. For me, it is fun to banter
a bit abou
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-215347141
I am not against this restructure perse. But shall we not try to change to
many things at once?
We have enough on our plates, so talking about leaving Maven se
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-215191105
@DaanHoogland I'm not sure about others, but gradle has become most popular
and widely-support in modern java development
@jburwell agree, the discussion here is t
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-215183202
+ 1 for moving away from maven. How about sbt?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-215177976
@rhtyd +1 for Gradle though it would be a large undertaking. Since
Gradle's Java plugin natively supports Maven's directory structure, such a
transition would act
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-215176727
@rhtyd I agree we should. At the moment we are already in an intermediate
state. Some projects were moved to maven standard (I only know utils by head
and the
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-215172757
In my experience when you are doing a lot of backporting or forward-porting
work, if a plugin/module has got its filesystem structure (for example, due to
moving to m
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-215131396
@swil @rhtyd this is the follow up of #1348. The initial rat failure was
genuine but next files where found that are .gitignored. not sure what happened
---
I
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1521
Kvm plugin restructure
test and project restructure without functional implications
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Daa
17 matches
Mail list logo
