Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/658
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/658#issuecomment-129801929
@manuiiit Nice. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/658#issuecomment-129336998
@manuiiit Thanks! Final request: please squash the 3 commits you have now
into one. After that, force push to this branch. Once done, I'll LGTM and merge.
---
I
Github user manuiiit commented on the pull request:
https://github.com/apache/cloudstack/pull/658#issuecomment-129300171
@remibergsma I used it for debugging purpose as a build failed.Removed it
now.Thanks.
---
If your project is set up for it, you can reply to this email and have yo
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/658#issuecomment-129228123
@manuiiit It seems an extra change got in (tools/travis/before_install.sh)
apart from the template permission issue. Please remove it from this PR as it
is not r
Github user manuiiit commented on the pull request:
https://github.com/apache/cloudstack/pull/658#issuecomment-128686845
@wido Ya I checked it.Any user was able to change permissions of the
template.Updated the description with a case i tried.
---
If your project is set up for it, yo
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/658#issuecomment-128686068
Code LGTM, but is it the case right now that anybody can change a template?
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user manuiiit opened a pull request:
https://github.com/apache/cloudstack/pull/658
Implemented condition that only admin or owner of the template can change
its permissions
. using updateTemplatePermissions API
You can merge this pull request into a Git repository by ru
