Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1474
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-218649126
Thank you sir. I will get this merged...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-218607576
LGTM. Tested in a hardware lab.
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-218466093
I need one more code review and this one should be ready to merge.
@kiwiflyer did you have a chance to review this one?
---
If your project is set up for it, you ca
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-218465795
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 4h 32m 05s
```
**Associ
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-215494066
cool thanks. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-215492977
We're pulling this in for testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-208803326
LGTM in spite of comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1474#discussion_r59343588
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py ---
@@ -274,3 +277,46 @@ def __moveFile(self, origPath, path):
os.ma
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1474#discussion_r59342176
--- Diff:
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
---
@@ -260,6 +261,15 @@ public boolean finalizeVirtualMac
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1474#discussion_r59341831
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py ---
@@ -274,3 +277,46 @@ def __moveFile(self, origPath, path):
os.ma
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-208795019
@swill I don't think many people read spurious comments on the github PRs.
only fanatics do :p
I am for safeguarding as much history as possible and only r
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-208590690
I will add this to my CI queue. Do we want to maintain commit history for
the two commits in this case?
Also, I am looking for code reviews on this one. Tha
13 matches
Mail list logo
