[GitHub] cloudstack pull request: GetUsageRecordsCmd - NewInputFormat for S...

2015-04-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/185#issuecomment-95912561 @svscorp yes please, I tried to cherry-pick the change but it failed. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: GetUsageRecordsCmd - NewInputFormat for S...

2015-04-24 Thread svscorp
Github user svscorp commented on the pull request: https://github.com/apache/cloudstack/pull/185#issuecomment-95872015 @bhaisaab Oh yes, it would be perfect. Should I make a PR, Rohit? --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack pull request: GetUsageRecordsCmd - NewInputFormat for S...

2015-04-24 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/185#issuecomment-95871580 @svscorp Thanks, do you want to merge this on 4.5 branch as well? --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cloudstack pull request: GetUsageRecordsCmd - NewInputFormat for S...

2015-04-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: GetUsageRecordsCmd - NewInputFormat for S...

2015-04-23 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/185#issuecomment-95800447 @svscorp Commit looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cloudstack pull request: GetUsageRecordsCmd - NewInputFormat for S...

2015-04-23 Thread svscorp
Github user svscorp commented on the pull request: https://github.com/apache/cloudstack/pull/185#issuecomment-95592190 After making more tests, there is one more commit added to remove unnecessary adjustToDayStart/End code, since ParamProcessWorker is actually taking care of building

[GitHub] cloudstack pull request: GetUsageRecordsCmd - NewInputFormat for S...

2015-04-23 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/185#issuecomment-95586207 LGTM! Thanks for the PR @svscorp I'll wait if @kishankavala wants to review --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack pull request: GetUsageRecordsCmd - NewInputFormat for S...

2015-04-21 Thread svscorp
GitHub user svscorp opened a pull request: https://github.com/apache/cloudstack/pull/185 GetUsageRecordsCmd - NewInputFormat for START_DATE and END_DATE It is extremely useful to be able to narrow the output to the specific time range within a date. You can merge this pull request