Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-150012697
### VMware vSphere API version from 5.1 to 5.5:
Since vSphere API version 5.5,
[OpaqueNetworks](https://www.vmware.com/support/developer/converter-sdk/conv55_api
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-149582907
@miguelaferreira @remibergsma
Thanks again for your help! As you suggested I rebased master branch. I
also added a more detailed description of the patch on th
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-149018797
@nvazquez Thanks for your work on the commits, they are much better now. I
would say it can easily be improved even further, but given the current
practice i
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-148929405
@nvazquez Thanks for your reply. If you made this from 4.5.1, be aware that
you submitted it against current master so this will for sure cause problems.
That ma
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-148715124
Hi @miguelaferreira @remibergsma
Thanks a lot for your help. I will try to make a better description of the
problem and work on commits and code as you sug
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-148704543
Hi @nvazquez Please reorganise your commits, as we need them to be atomic.
It cannot go in like this.
I'm also with @miguelaferreira, please let us know
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-148639781
Hi @nvazquez
Thanks for your contribution. I'm not quite sure I understand the problem
you are trying to solve, but that likely my own lack of NXS k
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/935#discussion_r42216002
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java ---
@@ -1079,8 +1088,10 @@ private static void createNvpPortGro
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/935#discussion_r42216007
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java ---
@@ -1101,6 +1112,12 @@ private static void createNvpPortGro
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/935#discussion_r42215862
--- Diff:
services/console-proxy-rdp/rdpconsole/src/test/java/rdpclient/MockServerTest.java
---
@@ -161,7 +161,8 @@ public void testIsMockServerC
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/935#discussion_r42215794
--- Diff:
plugins/network-elements/nicira-nvp/src/com/cloud/network/resource/NiciraNvpResource.java
---
@@ -191,6 +204,19 @@ public PingCommand g
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/935#discussion_r42215621
--- Diff:
plugins/network-elements/nicira-nvp/src/com/cloud/network/resource/NiciraNvpResource.java
---
@@ -191,6 +204,19 @@ public PingCommand g
Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/935#discussion_r42215505
--- Diff:
plugins/network-elements/nicira-nvp/src/com/cloud/network/resource/NiciraNvpResource.java
---
@@ -180,6 +182,17 @@ public Type getType(
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/935
From4.5.1: NSX/Nicira Plugin does not support NSX v4.2.1
JIRA Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-8956
You can merge this pull request into a Git repository by running:
14 matches
Mail list logo
