Github user The-Loeki commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r65132038
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -1207,33 +1145,27 @@ setup_secstorage() {
fi
setup_apache2 $
Github user The-Loeki commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r65131979
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -1207,33 +1145,27 @@ setup_secstorage() {
fi
setup_apache2 $
Github user The-Loeki commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r65131836
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -801,38 +802,29 @@ setup_sshd(){
setup_vpc_apache2() {
log_it
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r65104294
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -1207,33 +1145,27 @@ setup_secstorage() {
fi
setup_apache2 $ETH2_
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r65104266
--- Diff: systemvm/patches/debian/config/etc/apache2/vhost.template ---
@@ -83,10 +83,15 @@
Allow from 127.0.0.0/255.0.0.0 ::1/128
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r65103774
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -801,38 +802,29 @@ setup_sshd(){
setup_vpc_apache2() {
log_it "Sett
Github user linas-h1p commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-220058896
Alright I posted in dev@ regarding other issues i'm noticing (Subject:
Additional Subnets for networks and VR dhcp), because it seems it doesn't apply
to thi
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-220043104
'aight, pulling that string reveals a few more problems to fix
unfortunately.
* `cloud-init-early` shell script creates/modifies `ports.conf`, `default`,
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-220022831
@linas-h1p tnx for the intel. Strange that I didn't encounter this, I'll go
check
---
If your project is set up for it, you can reply to this email and have your
Github user linas-h1p commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-220014434
Seems to be ok now. Thanks for the quick fix.
Another issue:
With the remade apache config generation, i see you are either putting
multiple Listen di
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63692269
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -82,7 +82,10 @@ def get_dns(self):
conf = self.cmdline().id
Github user The-Loeki commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63691374
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -58,25 +58,35 @@ def get_level(self):
return self.__LOG_LEVEL
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-220004141
@linas-h1p thanks for noticing, that fix got lost in commit msg translation.
I've amended the `CsAddress.py` commit to (un)fix the whitespacing &
readded
Github user linas-h1p commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219951759
Disclaimer: i'm very new to the whole ACS, but i have built and deployed
custom releases for ourselves. I understand the project structure somewhat.
So..
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219950557
@DaanHoogland I haven't touched this code much. @The-Loeki ran into this
issue when working on our Private Cloud (which is where we test upgrades first).
We do
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219911999
I have seen these errors on two other PRs tonight, so I don't think they
are related to this PR. I think this is a pretty clean CI result. I need to
track down wher
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219911797
### CI RESULTS
```
Tests Run: 83
Skipped: 0
Failed: 0
Errors: 2
Duration: 8h 52m 19s
```
**Summary of the p
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219841186
@swill I think @ustcweizhou has a point. So at least that one commit
tag:needslove. The rest should pass our regular suite. We can also create a
Marvin defini
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219831758
I think we can ignore a lot of this. My tests are mainly setup to test
advanced networking. I have to revisit this to know how to test the basic
networking stuff co
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219827463
### CI RESULTS
```
Tests Run: 57
Skipped: 0
Failed: 18
Errors: 37
Duration: 2h 54m 41s
```
**Summary of the
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63569193
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -58,25 +58,35 @@ def get_level(self):
return self.__LOG_LEVE
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219760013
I am currently testing this in both a basic and advanced zone. I will post
results when I have them...
---
If your project is set up for it, you can reply to this e
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219754165
Maybe, but for now it's still just one conditional which needs just one
decision/explanation.
On the plus side, if the decision can be taken in CsConfig corre
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219712536
@The-Loeki maybe it makes sense to split the PR, especially on the part
where there is discussion.
---
If your project is set up for it, you can reply to this
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219709644
@DaanHoogland is correct; we're running this code in test-production. Keep
in mind however that we only use Basic Networking Zones, so I did my best to
keep the b
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219409102
@ustcweizhou the integration tests are functional tests. If there is extra
functionality to be tested please provide the test for it. And at least
describe wha
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63342702
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -58,25 +58,35 @@ def get_level(self):
return self.__LOG_LEV
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219358546
guys, please donot merge the changes on VR before a LGTM with functional
testing.
the changes on VR should be careful and careful.
a code review and an i
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63314291
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -58,25 +58,35 @@ def get_level(self):
return self.__LOG_LEVE
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219300088
@swill can you schedule this one. Would be nice to get in before freeze.
Mine test effort failed (see dev@)
---
If your project is set up for it, you can repl
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219274189
code looks clean. I don't understand all if it yet so I may ask questions
yet. but anaother set of eyes required;
tag:needsreview
---
If your project is s
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219273429
started the integration tests on this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219121539
I like the first two.
The third should read something like:
CLOUDSTACK-8303 allow multiple ranges & finite lease time
the 4th and 5th I really need t
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219094194
Like this then :dart:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219063444
:+1: maybe squash the conflict entries out?
you can rebase -i HEAD^7 and then reorder the commits. If you put the last
one at position 3 and change the pref
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219062321
@DaanHoogland like it better now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63188515
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -66,8 +66,13 @@ def is_router(self):
def get_domain(self):
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219054423
@The-Loeki those don't show in a short listing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219053999
@The-Loeki 6 commits with the same message is not helpful and indeed
confusing. Can you change them to shortly describe the individual fixes, or if
you must sq
Github user The-Loeki commented on the pull request:
https://github.com/apache/cloudstack/pull/1547#issuecomment-219054107
@DaanHoogland click on the (...) :dancers:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user The-Loeki commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1547#discussion_r63188699
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsConfig.py ---
@@ -66,8 +66,13 @@ def is_router(self):
def get_domain(self):
GitHub user The-Loeki opened a pull request:
https://github.com/apache/cloudstack/pull/1547
Fixes for VirtualRouters in Basic Networking, especially with mutliple
ranges in VLANs
During the last few modifications on the SystemVM scripts, it turns out
quite a lot of stuff broke in o
42 matches
Mail list logo
