Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/219
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/219#issuecomment-98095126
In the current usage of it, they are utf8. Also, it uses UTF-8 for the key.
I will go ahead and merge. Thanks for the review Daan.
---
If your project is s
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/219#issuecomment-98087976
travis has errors in one of the jobs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/219#issuecomment-98087059
LGTM. If you are sure the bytes are always UTF8 and not platform defined,
this is fine.
---
If your project is set up for it, you can reply to this email and ha
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/219
Fixed two coverity reported issues
Dereference after null check
Dm: Dubious method used
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/