Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1438
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1438#issuecomment-204045871
I opened #1427 and I agree, @rafaelweingartner and @swill so please go
ahead. I will close #1427
---
If your project is set up for it, you can reply to this
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1438#issuecomment-204006448
I agree, but I was the one that opened the PR, so in my opinion, my opinion
should no count much here :)
---
If your project is set up for it, you can re
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1438#issuecomment-204005852
I think we should probably merge this one and not #1427. Do you agree?
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1438#issuecomment-204001802
Tests were performed and reviews executed; so, should we merge this or the
#1427?
---
If your project is set up for it, you can reply to this email and h
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1438#issuecomment-203997224
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1438#discussion_r57527860
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
---
@@ -395,16 +391,9
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1438#issuecomment-201476824
I don't think these tests failing are relevant to this change. We agree
this is ready to be merged? Only against master?
---
If your project is set up for it, you
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1438#discussion_r57485802
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
---
@@ -395,16 +391,9 @@ protected
Github user pvr9711 commented on the pull request:
https://github.com/apache/cloudstack/pull/1438#issuecomment-200255385
@swill @DaanHoogland tested this PR - LGTM.
All BVTs have passed with the exception of the following tests
- test_07_list_default_iso - iso didn't exist.
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1438#discussion_r55938944
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
---
@@ -395,16 +391,9
GitHub user rafaelweingartner opened a pull request:
https://github.com/apache/cloudstack/pull/1438
Fix new error found in findbugs slow build #3455
Fix new find bug error that was introduced in PR #1361
Report:
http://jenkins.buildacloud.org/job/build-master-slowbuild/3455/fin
12 matches
Mail list logo
