Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133570169
@DaanHoogland It does fix the problem, I just feel a bit blind sometimes by
the builds that seem less reliable lately so then it's hard to be sure.
But anywa
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133567885
hm, you shouldt merge anything to a broken master that isn't hellbound on
fixing it.
---
If your project is set up for it, you can reply to this email and have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133567102
Check, as far as I can tell everything is OK. And since master is broken
now anyway, I think it's time to merge this to fix it.
---
If your project is set up fo
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/726
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133552422
I think we have to disable this test, enlarging the period even more beats
every intention of its use. not related indeed
---
If your project is set up for it,
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133546545
cloudstack-pull-analysis 296 failed due to: `Expected exactly 2 but it took
more than 3 microseconds between 2 consecutive calls to System.nanoTime().`
Seems not
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133544954
LGTM Verified that a new cloud deployment had working system VMs again.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133467580
@borisroman Thanks! I'll run some tests later tonight. Travis is green,
didn't see an Apache build reporting results (yet?).
---
If your project is set up for i
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133408184
@karuturi I came to that conclusion in the previous pr. I will stack all
refactoring work in a branch. And send a PR when done.
---
If your project is set up for
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133406706
LGTM. lets wait for travis and other jenkins verifications.
In future, can you club all refactoring work in a branch and merge them
together? That way, we c
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133399200
@remibergsma @karuturi Please review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133398943
Tested it in a new environment. The nics are correctly put in the db again.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133397841
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133395038
The updateBuilder will check if the DAO has changed based on the set*()
methods. When it can't resolve one, it won't update. After learning this I
changed the set
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/726
Fix for the NicVO.java regression.
Renamed set*() methods to correct naming.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cl
15 matches
Mail list logo
