Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/460#issuecomment-112344047
@DaanHoogland done!
https://github.com/apache/cloudstack/pull/464
I should have checked travis for this one, still my bad :(
---
If your project is set up
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/460#issuecomment-112339045
please make it a seperate fix, not an update. I jumped the gun.
On Tue, Jun 16, 2015 at 10:36 AM, Rafael da Fonseca <
notificati...@github.com> wrote
I think it's caught and also that the pull request builder doesn't
build -Dnoredist. I will check and fix if so
On Tue, Jun 16, 2015 at 10:36 AM, rsafonseca wrote:
> Github user rsafonseca commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/460#issuecomment-112338005
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/460#issuecomment-112338005
my bad there.. will surround in try/catch block and update
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/460#issuecomment-112333921
I shouldn't have:( exception uncought. Really curious why the pull request
builder accepted this.
---
If your project is set up for it, you can reply to this e
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/460
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/460#issuecomment-112313538
thanks, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/460#issuecomment-112232241
Here's an example of an instance where i also removed a
Charset.defaultCharset() that was placed in the reading of a socket, where
cloudstack controls both ends -
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/460#discussion_r32469324
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -2265,7 +2265,7 @@ public Answer forgetObject(F
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/460#discussion_r32465788
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -2265,7 +2265,7 @@ public Answer forgetObject
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/460
Fix findbugs encoding issue in VmwareStorageProcessor.java
Any encoding would do fine as it's just used to generate a UUID. Sticking
with UTF-8 for consistency
You can merge this pull reques
11 matches
Mail list logo
