Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/462
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/462#issuecomment-112313034
convinced, the router is a debian box (for now and will remain linux in the
near future.
LGTM
---
If your project is set up for it, you can reply to t
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/462#discussion_r32472663
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -705,7 +705,7 @@ public ExecutionResult creat
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/462#discussion_r32466095
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -705,7 +705,7 @@ public ExecutionResult cre
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/462
Fix findbugs encoding issue in VmwareResource.java
Key file should be UTF-8 encoded in VR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/