Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1127
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1127#issuecomment-160217770
regression tests pass:
[1127.network.results.txt](https://github.com/apache/cloudstack/files/46140/1127.network.results.txt)
[1127.vpc.results.txt](htt
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1127#issuecomment-159889944
Thanks @ProjectMoon
:+1: from me based on my previous tests.
ping @remibergsma and @DaanHoogland to merge
---
If your project is set up for it, you can r
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159889056
Closed in favor of #1127.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user ProjectMoon closed the pull request at:
https://github.com/apache/cloudstack/pull/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
GitHub user ProjectMoon opened a pull request:
https://github.com/apache/cloudstack/pull/1127
Fix event UUIDS missing on event bus
Same as pull request #, but this time on the 4.6 branch for forward
merging in accordance with [the
wiki](https://cwiki.apache.org/confluence/displ
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159887285
Since the branches are different, I will create a new branch off of 4.6,
cherry-pick my commit to it, and then submit that as a new PR, which can then
be forwar
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159884682
No cherry-picking. The PR should be only for 4.6 which will be fwd-merged
to master(and hence will be available in 4.7 and up)
I wish it was as easy as editing
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159883807
Well, the target branch for this is master so it will be put in
4.7-SNAPSHOT, but it's also intended to be cherry-picked back into 4.6 (which I
obviously do not
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159883325
I just realised the target branch should be 4.6 meaning the PR should be
for 4.6 and fwd-merged to master. Can you take care of that please @ProjectMoon
---
If y
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159834948
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159834901
```
Check the password file in the Router VM ... === TestName:
test_isolate_network_password_server | Status : SUCCESS ===
ok
-
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159833976
@ProjectMoon there was one failure in the network tests for the password
server. I am rerunning that one to make sure.
[.network.results.txt](https://g
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159586201
@karuturi I don't think there is a test for this in the suites we use. I'll
them anyway to at least see about regression in some other places.
---
If your pro
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159568824
@remibergsma @DaanHoogland can you take a look at this please? Its a good
fix to have in 4.6.1
I didnt run the test suite. But, manually tested this fix.
---
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159519154
manually tested it with rabbitmq integration
Here are the events before and after the fix
Before:
{"eventDateTime":"2015-11-25 11:39:27
+0530"
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159341450
Example with the fix:
```
{
eventDateTime=2015-11-24 16:57:58 +,
status=Completed,
description=Successfully completed enabling
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159318964
Hi @ProjectMoon Thanks for taking this up. If possible, can you put in a
sample event before and after the fix?
I will test this tomorrow with rabbitmq
---
I
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159277838
The commit has been updated with a unit test. I also rebased this branch to
latest master since my apparent accidental review of #1110 got the syntax error
fix
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159231415
For now I will cherry-pick that commit and use it locally to build my
tests. It will not become part of this pull request of course.
---
If your project is set
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159230031
It is missing a review and LGTM, (with proper motivation)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159219262
Currently unable to build the branch due to
https://github.com/apache/cloudstack/pull/1110. What's the status of that
request being merged in?
---
If your pro
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159042018
Yes, preferably but not necessarily. you can create your own if you want,
based on scripts and cloudmonkey for instance or a similar tool.
---
If your project
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159024273
Integration tests use Marvin, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159001728
@ProjectMoon server/test/com/cloud/event/ActionEventUtilsTest.java
and if you can maybe an integration test?
---
If your project is set up for it, you
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/#issuecomment-159001385
To test, remote debug an in-memory event bus with a command like disable or
enable static NAT. Check event description property before and after. If this
commit
GitHub user ProjectMoon opened a pull request:
https://github.com/apache/cloudstack/pull/
Fix event UUIDS missing on event bus
The fixing of CLOUDSTACK-8816 introduced a regression that removed the
first class entities in the event bus description property. This is because
ever
27 matches
Mail list logo
