[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...

2015-10-06 Thread milamberspace
Github user milamberspace closed the pull request at: https://github.com/apache/cloudstack/pull/912 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...

2015-10-06 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/912#issuecomment-146095698 Closed. New PR #915 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...

2015-10-06 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/912#issuecomment-145985072 @DaanHoogland you need to double-check that the old zoneWizard.js file is changed on you browser (clean cache) and on the tomcat installation (if not a new ins

[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...

2015-10-06 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/912#issuecomment-145853416 I tried to run the wizard with this patch applied but the wizard doesn't show 'finished' nor does it finish after pressing 'next' for a final time. I shows a bl

[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...

2015-10-05 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/912#issuecomment-145668698 @runseb Good catch! Thanks @nitin-maharana to fix part of this bugs. @remibergsma my PR add a bug on Adv search label. --- If your project is set up

[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...

2015-10-05 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/912#issuecomment-145661229 @milamberspace @remibergsma there is a duplicate at https://github.com/apache/cloudstack/pull/906 --- If your project is set up for it, you can reply to this email a

[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...

2015-10-05 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/912#issuecomment-145655920 @milamberspace Thanks, this we should include indeed. Will try to test in the coming days. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...

2015-10-05 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/912#issuecomment-145455703 @remibergsma Probably this is a 'minor' blocker bug for the 4.6 release. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cloudstack pull request: Fix bugs on last step on Wizard zone and ...

2015-10-05 Thread milamberspace
GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/912 Fix bugs on last step on Wizard zone and Adv Search box Javascript error: Uncaught ReferenceError: _ is not defined => Missing 'l' (to call the _l() function) Bug introduce by